STEBBS improvement

[sunt05]

The only improvement needed is to reorganise the newly introduced states:

• Many of the setting parameters should be moved to the config section.
• Radiation fluxes from BEERS can be retrieved from the heat state.

I'll work on this some more this afternoon and then leave any remaining tasks with you.

Originally posted by @sunt05 in #307 (review)

[sunt05]

Hi @MatthewPaskin, is this resolved now? If so, please close it. Thanks!

[MatthewPaskin]

@sunt05 Only the radiation fluxes have been changed. It would be good to discuss how the other parameters should be moved (point 1)

[sunt05]

OK, I'll review it and suggest changes if needed—likely later today.

@MatthewPaskin Could you confirm whether all your previous updates on this have been integrated into the active pydantic branch? Or should I check a different branch?

[MatthewPaskin]

@sunt05 These changes should be in 299 which 324 (current pydantic) was branched from, so both branches should have these changes

[sunt05]

Hi @MatthewPaskin, I've separated the parameters and states in the original STEBBS_STATE.
Now we have a new STEBBS_PRM, while STEBBS_STATE has been streamlined to include only temperatures meant to be updated during simulation.
However—and I might be mistaken here—I noticed that state variables (e.g., initial temperatures) seem to be used solely as input without being fed back for updates. Could we have missed something?

Since the STEBBS model is shaping up well, I think it’s worth ensuring these details are correct before including it as a preview feature in the forthcoming release. Let’s double-check this and make sure everything works as expected!

[MatthewPaskin]

Hi @sunt05, thanks for raising this, I will take a look tomorrow and we can figure out where to go from there