Module 2 Associating Incorrect Assessment Units to a Monitoring Station near Lake Erie

[jesseboormanpadgett]

Describe the bug

I was testing Module 2 near Cleveland and found something odd. As you can see in the attached screenshot, the monitoring location on the Lake Erie shoreline got associated with the OH041100030504 assessment unit, which is actually the HUC-based AU to the south of this monitoring location.

I would have thought this monitoring location would have been associated with the Lake Erie Shoreline assessment unit (OHLE041202000203) or possibly the Lake Erie Open Water assessment unit (OHLE041202000303). The monitoring location point appears closer to the Lake Erie assessment units and I think it is a beach monitoring location, which would make more sense to associate with Lake Erie assessment units.

I wonder if since it is still on the land, it intersected with land-based catchments instead of the hexagon-based ocean catchments, making TADA associate it with a land-based assessment unit. If that is the case, this could be a problem for all beach monitoring locations that land on the beach and not in the lake/bay/ocean.

To Reproduce

Steps to reproduce the behavior:

1. Load the Module 2 Vignette using the below code under Make Spatial

4. Load Leaflet to see the error

Code to reproduce the behavior:

TADA_dataframe <- TADA_DataRetrieval(
startDate = "2020-01-01",
endDate = "2020-12-31",
characteristicName = ,
countycode = "US:39:035",
applyautoclean = TRUE

Expected behavior

Module 2 would associate the monitoring location with the closest assessment unit.

Screenshots

Additional context

Add any other context about the problem here.

Reminders for TADA contributors addressing this issue

Bug fixes should include all the following work:

• Create or edit the function/code.

• Document all code using line/inline and/or multi-line/block comments
  to describe what is does.

• Create or edit tests in tests/testthat folder to help prevent and/or
  troubleshoot potential future issues.

• Create or edit the function documentation. Include working
  examples.

• Update or add the new functionality to the appropriate vignette
  (or create new one).

• If function/code edits made as part of this issue impact other
  functions in the package or functionality in the shiny app, ensure
  those are updated as well.

• Run TADA_UpdateAllRefs(), TADA_UpdateExampleData(), styler::style_pkg(),
  devtools::document(), and devtools::check() and address any new notes or
  issues before creating a pull request.

• Run more robust check for releases: devtools::check(manual = TRUE,
  remote = TRUE, incoming = TRUE)