Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional toggles are unselected if a user sorts table on flag tab #201

Open
5 tasks
cristinamullin opened this issue Jan 29, 2025 · 1 comment
Open
5 tasks

Comments

@cristinamullin
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When usability issue #160 was addressed, the sorting feature was added to the flag table.

Now, if a user selects any Flag Reason to Switch 'On' to flag for removal, and if a user then proceeds to try to sort by any column -- for example, if a user wants to toggle on "Coordinates are imprecise (less than three decimal digits) (see TADA.SuspectCoordinates.Flag)" and then they sort by 'Results affected', that toggle then gets deselected.

Image

Image

Describe the solution you'd like

I think it would be good if it's the case when a user selects to toggle a flag, if they were to then sort, the toggles that they've chose would stay the same.

Reminders for TADA contributors addressing this issue

New features and/or edits should include the following work:

  • Create or edit the code.

  • Document all code using line/inline and/or multi-line/block comments
    to describe what is does.

  • Create or edit tests in tests/testthat folder to help prevent and/or
    troubleshoot potential future issues.

  • If your code edits impact other functionality in the shiny
    app, ensure those are updated as well.

  • Run styler::style_pkg(), devtools::document(), and devtools::check()
    and address any new notes or issues before creating a pull request.

@cristinamullin
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant