Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing abbreviations, and sorting for them #18

Open
martindholmes opened this issue Dec 30, 2024 · 5 comments
Open

Missing abbreviations, and sorting for them #18

martindholmes opened this issue Dec 30, 2024 · 5 comments
Assignees
Labels
bug Something isn't working data interpretation/processing Issue related to how the source data should be interpreted or processed data quality Issue relating to errors or problems with the source data itself help wanted Extra attention is needed

Comments

@martindholmes
Copy link
Member

Per DS, the abbreviation "k" means "bankrupt", and also appears as bkrpt.

Other missing abbreviations are "b", "r", "s" and "t", and we don't yet know what those mean. The abbreviation table should also be sorted case-insensitively.

@martindholmes martindholmes added bug Something isn't working help wanted Extra attention is needed data quality Issue relating to errors or problems with the source data itself data interpretation/processing Issue related to how the source data should be interpreted or processed release-blocking Must be fixed before a new release can be made labels Dec 30, 2024
@martindholmes martindholmes self-assigned this Dec 30, 2024
@DavidJamesShaw
Copy link

'b' is 'born: it is already in the table of abbreviations.
Another one I have noticed is 'f' for 'freed' (i.e. end of apprenticeship). The abbreviation table has 'fr'.

@DavidJamesShaw
Copy link

I've checked the original CSV file: 'k' is almost always accompanied by a note of the date of bankruptcy.

's' appears to be the date of sale of the business.

't' : unknown: there are no accompanying notes.

'r' : couldn't find an example

martindholmes added a commit that referenced this issue Dec 30, 2024
…thers; linked variants; removed extraneous HTML name tags.
@martindholmes
Copy link
Member Author

@DavidJamesShaw For r, take a look at Christopher Abbey (https://hcmc.uvic.ca/project/bbti/orgs/org_8.html); the row in the spreadsheet of the linking table that links him to his primary trade (Bookbinder's toolcutter/toolmaker) has "r" in the "Class" column. That column contains either b, r, s, or t (and occasionally NULL) for all of its links rows up until row 124633, and thereafter they are all NULL, so presumably whatever it signified either became unimportant, or perhaps the people doing data entry themselves forgot or couldn't discover what any of the values meant.

@martindholmes
Copy link
Member Author

I've set the abbreviations to sort case-insensitively, and added some missing ones as suggested.

@martindholmes
Copy link
Member Author

Leaving this open for the unknown b, r, s, and t abbreviations in the trade class columns, but I think other than that, abbreviations are now working as expected (see issue #19).

@martindholmes martindholmes removed the release-blocking Must be fixed before a new release can be made label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data interpretation/processing Issue related to how the source data should be interpreted or processed data quality Issue relating to errors or problems with the source data itself help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants