-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing abbreviations, and sorting for them #18
Comments
'b' is 'born: it is already in the table of abbreviations. |
I've checked the original CSV file: 'k' is almost always accompanied by a note of the date of bankruptcy. 's' appears to be the date of sale of the business. 't' : unknown: there are no accompanying notes. 'r' : couldn't find an example |
…thers; linked variants; removed extraneous HTML name tags.
@DavidJamesShaw For r, take a look at Christopher Abbey (https://hcmc.uvic.ca/project/bbti/orgs/org_8.html); the row in the spreadsheet of the linking table that links him to his primary trade (Bookbinder's toolcutter/toolmaker) has "r" in the "Class" column. That column contains either b, r, s, or t (and occasionally NULL) for all of its links rows up until row 124633, and thereafter they are all NULL, so presumably whatever it signified either became unimportant, or perhaps the people doing data entry themselves forgot or couldn't discover what any of the values meant. |
I've set the abbreviations to sort case-insensitively, and added some missing ones as suggested. |
Leaving this open for the unknown b, r, s, and t abbreviations in the trade class columns, but I think other than that, abbreviations are now working as expected (see issue #19). |
Per DS, the abbreviation "k" means "bankrupt", and also appears as bkrpt.
Other missing abbreviations are "b", "r", "s" and "t", and we don't yet know what those mean. The abbreviation table should also be sorted case-insensitively.
The text was updated successfully, but these errors were encountered: