-
-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please start building each version before merging it to the main branch #2071
Comments
pr's to main and release branches have unit test, which means that the binaries for these are build, from that branch before they are merged. furthermore due to CuraEngine being a deps of Cura, there are nightlies being build for our QA each day, both from main as the latest release branch. Additional each ticket implemented by us has a corresponding build from the working branch made by our QA before merging to main or release. Additional statistical analysis tools are also run on each open PR for gcode output, speed benchmarks, stress tests. in otherwords our CI/CT is rather comprehensive. the issue you're referring to were simply the results of GitHub runner images being updated and missing certain system dependencies. These have been adressed. |
Thank you, this clarifies. For anyone looking for those builds, where can they be found? |
If you mean the stress tests, benchmarks and regression test these can be found here:
The unit tests themself are tied to the PR's adn require a ✔️ before you can merge. If you mean the actual binaries, these are upload to our jfrog artifactory for consumption by downstream projects (e.q. Cura) and are automaticaly used when doing a conan install for that project itself. If you tried that but you see that CuraEngine is still being build, that is because of ABI compatabilities, you're likely using an other architecture, os, compiler then we use in our build system our on our development systems |
@jellespijker Can the official release a markdown file to teach new user to build cura and curaengine step by step? i follow the github wiki but wrong. i had to google it to find the way. but it is not easy, there is too little relevant information. if we have an official markdown file , no need to ask your guys on github. what do you think? |
We've barely had 5.7.0 for a month and from what I see 5.7.1 is about to be released according to https://github.com/Ultimaker/CuraEngine/actions/runs/8782671105 but what's this? The pipeline doesn't compile anything. So this probably explains why this project has so many build issues - the issues do not become apparent to the developers before merging into the master branch.
The issues, just to name a few are:
Why is it like this?:
If the GitHub project would be configured to require that each PR must produce binaries, then the quality of the project would take a dramatic increase.
The text was updated successfully, but these errors were encountered: