Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI Scaling broken for CLI Config and Projects #1214

Open
braunms opened this issue Jul 19, 2023 · 0 comments
Open

GUI Scaling broken for CLI Config and Projects #1214

braunms opened this issue Jul 19, 2023 · 0 comments
Labels

Comments

@braunms
Copy link
Contributor

braunms commented Jul 19, 2023

GUI scaling is ignored when set via mmSetCliOption("guiscale", "1.5") or via mmSetGUIScale(1.500000) in a projcet file.

The first scale event comes from the config, the second from the project file and then a third one comes from OpenGL_GLFW_Service::glfw_onWindowContentScale_func, which then overwrites the value with 1again (at the default resolution).
This issue has been introduced with the feature "automatic gui scale based on monitor settings"
https://github.com/UniStuttgart-VISUS/megamol/blame/2eee5ee99e9b4f17e6ff742575a9202743523b5f/frontend/services/gui/src/GUI_Service.cpp#L227

GUI scaling works via GUI log console and GUI menu.

Solution

Reorder the scaling events depending on priority:

  1. GLFW scaling for automatic gui scale based on monitor settings
  2. CLI option
  3. project file
    ... but is this even possible??

Steps To Reproduce
Place mmSetGUIScale(1.500000) in a project file and start MegaMol. For default resolution 1920x1080 GUI scaling is still 1.

Expected behavior
GUI scaling should be 1.5

Additional Context
n.a.

@braunms braunms added the bug label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant