Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer links on any chain other than Mainnet are broken on Pool page #311

Open
0xTARC opened this issue Jan 15, 2024 · 2 comments
Open

Explorer links on any chain other than Mainnet are broken on Pool page #311

0xTARC opened this issue Jan 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@0xTARC
Copy link

0xTARC commented Jan 15, 2024

Bug Description
Explorer links on PoolPage are always linking to etherscan.io, regardless of the chosen chain

broken-explorer-link

Steps to Reproduce

  1. Switch chain to any chain other than mainnet. For example, switch to Optimism
  2. Navigate to any pool (for example, search OP and select the OP/WETH 30bps pool
  3. Click the explorer link
  4. Note you are taken to etherscan.io, not optimistic.etherscan.io

Repro video:
https://github.com/Uniswap/v3-info/assets/97852365/e032e098-4c76-450d-9ac5-15f8aeead3bf

Expected Behavior
Clicking the explorer link should navigate to the active chain's explorer

Additional Context
PR with fix: #308
@0xTARC 0xTARC added the bug Something isn't working label Jan 15, 2024
@robertu7
Copy link

Same issue on transaction links

image

@vani11aa vani11aa mentioned this issue Mar 20, 2024
Open
@Vanilladelphia
Copy link

Both issues fixed with PR #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robertu7 @Vanilladelphia @0xTARC