From d87cc5dccfa685930363d2dcaa342f182e27b334 Mon Sep 17 00:00:00 2001 From: Alex Cockrean <84676155+ABenC377@users.noreply.github.com> Date: Mon, 30 Dec 2024 13:14:12 +0000 Subject: [PATCH] Updating comments and docs in response to PR comments --- docs/sphinx/user/configuring_simeng.rst | 2 +- src/include/simeng/branchpredictors/BranchHistory.hh | 2 +- src/include/simeng/branchpredictors/TagePredictor.hh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/sphinx/user/configuring_simeng.rst b/docs/sphinx/user/configuring_simeng.rst index 66322b567..245c17809 100644 --- a/docs/sphinx/user/configuring_simeng.rst +++ b/docs/sphinx/user/configuring_simeng.rst @@ -183,7 +183,7 @@ Num-Tage-Tables Only needed for a ``Tage`` predictor. The number of tagged tables used by the predictor, in addition to a default prediction table (i.e., the BTB). Therefore, a value of 3 for ``Num-Tage-Tables`` would result in four total prediction tables: one BTB and three tagged tables. If no tagged tables are desired, it is recommended to use the ``GenericPredictor`` instead. Tage-Length - Only needed for a ``Tage`` predictor. The number of bits used to tage the entries of the tagged tables. + Only needed for a ``Tage`` predictor. The number of bits used to tag the entries of the tagged tables. .. _l1dcnf: diff --git a/src/include/simeng/branchpredictors/BranchHistory.hh b/src/include/simeng/branchpredictors/BranchHistory.hh index ab52b9980..105caa314 100644 --- a/src/include/simeng/branchpredictors/BranchHistory.hh +++ b/src/include/simeng/branchpredictors/BranchHistory.hh @@ -9,7 +9,7 @@ namespace simeng { * access and manipulate large branch histories, as are needed in * sophisticated branch predictors. * - * The bits of the branch history are stored in a vector of uint64_t values, + * The bits of the branch history are stored in an array of uint64_t values, * and their access/manipulation is facilitated by the public functions. */ class BranchHistory { diff --git a/src/include/simeng/branchpredictors/TagePredictor.hh b/src/include/simeng/branchpredictors/TagePredictor.hh index dedbc2f40..dabb07c00 100644 --- a/src/include/simeng/branchpredictors/TagePredictor.hh +++ b/src/include/simeng/branchpredictors/TagePredictor.hh @@ -118,7 +118,7 @@ class TagePredictor : public BranchPredictor { std::vector> btb_; /** The bitlength of the Tagged tables' indices. - * Each tagged table with have 2^bits entries. */ + * Each tagged table will have 2^bits entries. */ uint8_t tageTableBits_; /** The number of tagged tables in the TAGE scheme.