Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbrActive=True causes error when BRAlgorithm is not 18 #23

Open
chestnutcase opened this issue Sep 27, 2023 · 2 comments
Open

cbrActive=True causes error when BRAlgorithm is not 18 #23

chestnutcase opened this issue Sep 27, 2023 · 2 comments

Comments

@chestnutcase
Copy link
Contributor

The application parameter cbrActive is set to True by default. If left as true, running other BR algorithms like the centralized algorithms will result in an error because the CBR code assumes stationManagement.sensingMatrixCV2X exists, but this field is only populated when the BRAlgorithm is set to 18.

https://github.com/V2Xgithub/WiLabV2Xsim/blob/557c68d725aa7d423d00ebc946eb3e55b7234c2d/MatCBRcalculations/cbrUpdateCV2X.m#L19C41-L19C41

Would calculating CBR be meaningful for centralized algorithms as well? If we would like to support CBR when the BR algorithm is not 18, we need to populate the sensing matrix for all BR algorithm cases - i don't think this is unreasonable, UEs might be able to sense what channels are in use while also waiting for the command from control plane to decide which BR to use. Otherwise, we should disable CBR by default, and add an extra guard clause to make sure that CBR can only be active when the BR algorithm is 18.

@chestnutcase chestnutcase changed the title cbr_active=True causes error when BRAlgorithm is not 18 cbrActive=True causes error when BRAlgorithm is not 18 Sep 27, 2023
@xxxxxy211
Copy link

Me too, I found the same problem.

@VittorioTodisco
Copy link
Collaborator

Yes, cbrActive can cause an error if it is set to true for algorithms different than 18.
Nevertheless, running algorithms like 101 (random allocation) don't need the sensing to select resources. Therefore the execution is very fast.
I agree that it could make sense to calculate the CBR also for centralized algorithms (if needed), we just haven't been working anymore on such a topic for quite a while.
It is also well known that centralized algorithms will achieve better performances than the autonomous mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants