Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring of app.py #32

Open
LucasCampos opened this issue Mar 30, 2021 · 1 comment
Open

Restructuring of app.py #32

LucasCampos opened this issue Mar 30, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@LucasCampos
Copy link
Member

LucasCampos commented Mar 30, 2021

I have to preface this saying that the design of vb_tool was never great to start with. I think that now that we are about to add another mode, hybrid searchlight (check pull #31), we really have to reconsider our approach. My main issue is that there are far too many flags that depend on the specific mode, which can be super confusing.

I propose the following new design:

  • Each mode will have its own entry point (vb_searchlight, vb_fullbrain, etc)
  • The existing vb_tool would print a help message explaining the various entry points
    • A second idea is that we could have something like vb_tool [tool] --flag1 --flag2 (...). I am still in favour of the first one, though.

This would, of course, break backwards compatibility.

Do you think this is a good approach?

@LucasCampos LucasCampos added the enhancement New feature or request label Mar 30, 2021
@LucasCampos LucasCampos changed the title Restructuring of vb_toolbox.py Restructuring of app.py Mar 30, 2021
@claudebajada
Copy link
Member

I agree ... tend to think option 2 would be optimal.... But happy to discuss. We may also want to scrap the purely surface based approachs if we don't think they give optimal results.

Though I think we should still push the current hybrid approach first and then start thinking about major overhaul later.

On a related note, we need to think about how the GUI can cope with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants