Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge user product.json feature has failed when using --user-data-dir commandline. #1941

Closed
2 tasks done
kendling opened this issue Jun 25, 2024 · 2 comments
Closed
2 tasks done
Labels
bug Something isn't working stale

Comments

@kendling
Copy link

kendling commented Jun 25, 2024

Describe the bug

  1. Download and extract the zip package.
  2. Create the shortcut for VSCodium.exe.
  3. Modify the shortcut and add --user-data-dir for it.
  4. Produce user product.json from https://github.com/VSCodium/vscodium/blob/master/docs/index.md#extensions--marketplace.
  5. Start it via the shortcut.
  6. The instance using open-vix.org still.
  7. It can merge product.json when place in %AppDATA%\VSCodium\product.json

Please confirm that this problem is VSCodium-specific

  • This bug doesn't happen if I using data dir as protable user data in same folder as VSCodium.exe.

Please confirm that the issue/resolution isn't already documented

Expected behavior
VSCodium can merge it when product.json place in dir prass by --user-data-dir param.

Desktop (please complete the following information):

  • OS: Windows
  • Architecture: x64
  • Version: 10.0.22631.3807

Additional context
I reviewed the merge-user-product.patch file in repo.
The resolveUserProduct function call getUserDataPath using {} as cliArgs param, it that the problem?

@kendling kendling added the bug Something isn't working label Jun 25, 2024
@kendling kendling changed the title magere user product.json feature has failed when using --user-data-dir commandline. merge user product.json feature has failed when using --user-data-dir commandline. Jun 26, 2024
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment, and we'll keep it open. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the stale label Dec 24, 2024
@daiyam
Copy link
Member

daiyam commented Dec 24, 2024

It has been fixed in #2055 and #2066

@daiyam daiyam closed this as completed Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants