Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] entities do not correctly getcreated_at or modified_at set #848

Open
Morriz opened this issue Aug 14, 2024 · 4 comments
Open

[Bug] entities do not correctly getcreated_at or modified_at set #848

Morriz opened this issue Aug 14, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Morriz
Copy link

Morriz commented Aug 14, 2024

The problem

Like the title says. These props do not get set, which is a shame if one wants to check how old entities are.

Your device model

GT-AXE16000

Firmware type

Merlin

Firmware version

3.0.0.4.388.8_2_rog

Integration version with the issue

all

Method of the integration installation

HACS

What version and type of Home Assistant installation do you use

2024.8.1

Is there anything useful in the logs?

No response

Diagnostics information

No response

Additional information

No response

@Morriz Morriz added the bug Something isn't working label Aug 14, 2024
@github-project-automation github-project-automation bot moved this to Incoming in AsusRouter/HA Aug 14, 2024
@Vaskivskyi
Copy link
Owner

Please, elaborate a bit more on what exactly is the bug. Also, an example of such a feature from any other integration would be appreciated, because I am not sure I can fully understand this issue

@Vaskivskyi Vaskivskyi moved this from Incoming to Info Needed in AsusRouter/HA Aug 27, 2024
@Morriz
Copy link
Author

Morriz commented Sep 24, 2024

Those are native props of entities if I understand it correctly, so it is up to the creator of any entity to set those props upon creation/modification time. Just like in any other stateful app?

Now I only see asusrouter creating entities that have those props unset. (Check changes in the underlying yaml files that are used for state storage in HASS, and you will see what I mean.)

I would expect devs be forced to use an api to create devices and entities, such that the wrapping layer would take care of such low level manipulation, but it seems not the case. I am disappointed by the HASS team that they did not follow up on their own design choices. I would force integration devs to use a base set of props and either validate those or set at db write time.

@Vaskivskyi
Copy link
Owner

@Morriz, so, you cannot see the history of the AsusRouter entities?

image

@Morriz
Copy link
Author

Morriz commented Sep 25, 2024

Indeed, I can not see the modified date of the tracker devices, making it impossible to see if they are ready for deletion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Info Needed
Development

No branches or pull requests

2 participants