Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Browser Provider] Support browser type #815

Closed
eliat123 opened this issue May 2, 2022 · 4 comments
Closed

[Browser Provider] Support browser type #815

eliat123 opened this issue May 2, 2022 · 4 comments

Comments

@eliat123
Copy link
Contributor

eliat123 commented May 2, 2022

Whenever using the Browser idp-provider, the default launched browser is Chromium, which the playwright-go package supports by default.

This behaviour is acceptable in most cases; however, when there are specific self-signed trust certificates, the default Chromium does not recognize installed certificates and already trusted CAs, and there is a prompt to approve them.

To fix it, we would like to add to the saml2aws configuration a browser_type property for the Browser Idp-provider, which will set it in the playwright launch configuration.

@MatteoJoliveau
Copy link

MatteoJoliveau commented Jul 5, 2022

Cross-linking my comment on the relevant PR: #816 (comment)

This feature would allow saml2aws to work flawlessly on NixOS/other non-FHS linux distributions, which are broken at the moment.

@merusso
Copy link

merusso commented Jan 22, 2023

Personally, I'd love it if this feature would use the system's default browser instead of downloading a playwright browser, if that's possible (#729).

@merusso
Copy link

merusso commented Jan 22, 2023

Cross-linking my comment on the relevant PR: #816 (comment)

This feature would allow saml2aws to work flawlessly on NixOS/other non-FHS linux distributions, which are broken at the moment.

@MatteoJoliveau, I'm not sure about this statement. I asked for clarification on the PR: #816 (comment)

@eliat123
Copy link
Contributor Author

Closing as #816 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants