Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Add filter for media/source type #1517

Open
andreoda opened this issue Aug 13, 2021 · 7 comments
Open

Search: Add filter for media/source type #1517

andreoda opened this issue Aug 13, 2021 · 7 comments
Labels
complexity: unknown Unknown days of work content: search Search content: songs Song entries feature request media Media playback (embeds) priority: low Issues/Tasks that are not so important

Comments

@andreoda
Copy link
Member

Currently we only have the option to search for:

  • no original media
  • no media
    and
  • only with PVs

I think it would be useful to include the type of media as well. For example:

  • NicoNicoVideo
  • YouTube
  • bilibili
  • SoundCloud

Based on the the media types that are currently supported as embeds.

I am not sure though, if it should be "only original media" or if it should include reprints as well as default.

@andreoda andreoda added content: search Search content: songs Song entries media Media playback (embeds) labels Aug 13, 2021
@Shiroizu
Copy link
Member

I am not sure though, if it should be "only original media" or if it should include reprints as well as default.

The current API implementation includes reprints as well, so it should probably mirror the same behaviour.

@ycanardeau
Copy link
Contributor

You can use the songs API call with the parameter pvServices. For example, use https://vocadb.net/api/songs?pvServices=YouTube and https://vocadb.net/api/songs?pvServices=SoundCloud for YouTube and SoundCloud, respectively.

These are all possible values of pvServices:

public enum PVServices
{
Nothing = 0,
NicoNicoDouga = PVService.NicoNicoDouga,
Youtube = PVService.Youtube,
SoundCloud = PVService.SoundCloud,
Vimeo = PVService.Vimeo,
Piapro = PVService.Piapro,
Bilibili = PVService.Bilibili,
File = PVService.File,
LocalFile = PVService.LocalFile,
Creofuga = PVService.Creofuga,
Bandcamp = PVService.Bandcamp,
}
.

@andreoda
Copy link
Member Author

Oh okay. How do I use it? I want to find songs that have no YT PV added.

@ycanardeau
Copy link
Contributor

Hmm, I think it's impossible with the current API implementation.

@Shiroizu
Copy link
Member

If it's a one time thing, you could use the datadump to get the entries with no Youtube PVs.

@CatgirlFrostmoon
Copy link

Given that this topic got reopened on VocaDB itself, consider this a vote towards PV search functions, once again.

@ycanardeau
Copy link
Contributor

mentioned

@ycanardeau ycanardeau reopened this Jan 22, 2022
@ycanardeau ycanardeau self-assigned this Jan 22, 2022
@ycanardeau ycanardeau removed their assignment Apr 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2022
@VocaDB VocaDB unlocked this conversation Aug 12, 2022
@ycanardeau ycanardeau transferred this issue from VocaDB/vocadb Aug 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
@VocaDB VocaDB deleted a comment from github-actions bot Apr 26, 2023
@VocaDB VocaDB unlocked this conversation Apr 26, 2023
@andreoda andreoda reopened this Jun 15, 2023
@andreoda andreoda transferred this issue from VocaDB/community Jun 15, 2023
@andreoda andreoda added complexity: unknown Unknown days of work and removed good first issue labels Mar 6, 2024
@andreoda andreoda added the priority: low Issues/Tasks that are not so important label Mar 23, 2024
@andreoda andreoda changed the title More filters for search: media/source type Search: Add filter for media/source type Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: unknown Unknown days of work content: search Search content: songs Song entries feature request media Media playback (embeds) priority: low Issues/Tasks that are not so important
Projects
Status: In progress
Development

No branches or pull requests

4 participants