Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Language Display - Submit a song #1821

Closed
5 of 7 tasks
FireWall0123 opened this issue Oct 21, 2024 · 2 comments
Closed
5 of 7 tasks

[Bug report] Language Display - Submit a song #1821

FireWall0123 opened this issue Oct 21, 2024 · 2 comments
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: songs Song entries priority: low Issues/Tasks that are not so important text Text/Characters display (Markup language: Markdown) translation Translations to other languages

Comments

@FireWall0123
Copy link

Website (required)

VocaDB

Describe the bug (required)

When creating a new song entry and setting the song type to "Cover", the description box bottom-right always switches to Japanese regardless of the chosen display language.

To Reproduce (optional)

Steps to reproduce the behavior:

  1. Go to 'Submit a song'
  2. Click on 'song type' and change it to 'Cover'

Screenshots (optional)

Untitled.video.mp4

Checklist (required)

Fill out the checklist. Use strikethroughs or leave fields empty if you don't know or are unable to check/test.

  • Searched VocaDB/vocadb for duplicate issues.
  • Tested on the beta site.
  • Tested on different browsers (e.g. Firefox, Chrome, Safari, Edge).
  • Checked in private mode.
  • Cleared browser cache and cookies.
  • Checked the DevTools console.
  • Checked the syslog (mods+ only).
@FireWall0123 FireWall0123 added the bug/error Bugs and errors (timeout) label Oct 21, 2024
@FinnRG
Copy link
Member

FinnRG commented Oct 21, 2024

This is tied to the "Preferred display language" setting in the interface section of the user settings page. You only see this effect with the cover tag, because it's the only translated song type tag.

@Shiroizu @andreoda Should the tag description box use the "interface language" (UI elements) or the "display language" (entry titles, tag descriptions) setting?

@Shiroizu
Copy link
Member

@FinnRG - I think this kind of split is the most intuitive:

The line of UI/entry is blurred a little here, since the tag entry description is displayed as a part of the UI.

Based on the above distinction, I think in this case the behaviour is intended.

Ideally the edit instructions would be sourced from the wiki instead: #134 (comment)

@andreoda andreoda added translation Translations to other languages text Text/Characters display (Markup language: Markdown) content: songs Song entries adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) priority: low Issues/Tasks that are not so important complexity: unknown Unknown days of work labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: songs Song entries priority: low Issues/Tasks that are not so important text Text/Characters display (Markup language: Markdown) translation Translations to other languages
Development

No branches or pull requests

4 participants