Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM code escaping #45

Closed
d-dd opened this issue Mar 19, 2015 · 1 comment
Closed

PM code escaping #45

d-dd opened this issue Mar 19, 2015 · 1 comment

Comments

@d-dd
Copy link
Contributor

d-dd commented Mar 19, 2015

Coded messages like &&& become escaped and turn into &&& when sent through PM's.

The preview shows &&& so it's a little bit confusing when it turns out different.

I'm not sure if escaping is intended, but if it is maybe the preview should also show it escaped. It's such a minor thing but though I'd point it out. 🍡 Might be related or duplicate of # #38 or #39.

@riipah
Copy link
Member

riipah commented Mar 19, 2015

Previews are always rendered with marked JavaScript library. Messages are rendered server-side using MarkdownSharp. Marked includes built-in HTML sanitizer, while MarkdownSharp doesn't. Instead, the HTML is sanitized using .NET's built-in library which probably encodes those ampersands. So yeah, it's related to both tasks, mainly #39, and should be fixed when that task is done.

Additionally, since Markdown isn't exactly a standard, two different libraries might produce different results, there's nothing that can be done about that. There's CommonMark project for standardizing the Markdown syntax, but it's not finished yet.

@riipah riipah closed this as completed Mar 22, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants