Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow drag and drop a song on mobile #489

Closed
Nefere256 opened this issue Apr 7, 2019 · 3 comments · Fixed by #1145
Closed

Allow drag and drop a song on mobile #489

Nefere256 opened this issue Apr 7, 2019 · 3 comments · Fixed by #1145
Labels
complexity: low Around 1 day of work content: albums Album entries content: song lists Song list/Playlist entries content: songs Song entries frontend Presentation layer (visible to user) priority: low Issues/Tasks that are not so important UX/usability UX (User Experience): Methods for improving the usablitiy

Comments

@Nefere256
Copy link
Contributor

It's impossible to change order of songs on mobile. It can be done on desktop by drag and drop.

The workaround is to remove songs from a list before newly added song and add them again, which can be troublesome for songs with descriptions on song lists.

Song order change is used in album tracklist and song lists/pools pages.

Probably related to #6.

@Nefere256 Nefere256 added content: song lists Song list/Playlist entries content: albums Album entries frontend Presentation layer (visible to user) labels Apr 7, 2019
@riipah riipah added complexity: low Around 1 day of work UX/usability UX (User Experience): Methods for improving the usablitiy labels Apr 7, 2019
@riipah
Copy link
Member

riipah commented Apr 7, 2019

The editing features are especially not designed to be mobile friendly. The idea is that you would do most of the editing on a desktop. I understand that more and more people would want to do the editing on mobile too, but the editing features are still second priority for mobile support.

That said, I wonder if this could be solved just by adding a number field so you can move the song straight to a specific position, similar to Steam wish lists? That would be easy to implement, and would also be useful on desktop.

image

@Nefere256
Copy link
Contributor Author

Do you think about changing current song number text into modifiable field? I'm not sure if it would fit nicely into a song row, but we can give a try.

If drag and drop isn't an option, I thought about adding down/up arrows on every song row to change song order by one position. But your solution looks better since tracks usually has a fixed number on the tracklist and only few clicks (taps?) will be needed to set songs in correct order.

We can't forget about albums with multiple discs - I guess a number order change would work only within one disc. It would be easier to change disk number too, or we would have to uncheck "next disc" option to move the song into a desired place and recheck "next discs".

@ycanardeau
Copy link
Contributor

Probably we can use SortableJS. It works on mobile as well.

@ycanardeau ycanardeau added the priority: low Issues/Tasks that are not so important label Oct 11, 2020
@ycanardeau ycanardeau added this to the Likely Never milestone Nov 19, 2020
@andreoda andreoda added the content: songs Song entries label Jan 13, 2021
@github-actions github-actions bot added the Stale label May 21, 2021
@ycanardeau ycanardeau modified the milestones: Likely Never, Migrate to Bootstrap 5 (or similar) May 22, 2021
@github-actions github-actions bot removed the Stale label May 22, 2021
@github-actions github-actions bot added the Stale label Jul 22, 2021
@ycanardeau ycanardeau removed the Stale label Jul 22, 2021
@github-actions github-actions bot added the Stale label Sep 21, 2021
@ycanardeau ycanardeau self-assigned this Sep 21, 2021
@ycanardeau ycanardeau removed their assignment Jul 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
@VocaDB VocaDB deleted a comment from github-actions bot Apr 26, 2023
@VocaDB VocaDB deleted a comment from github-actions bot Apr 26, 2023
@VocaDB VocaDB deleted a comment from github-actions bot Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
complexity: low Around 1 day of work content: albums Album entries content: song lists Song list/Playlist entries content: songs Song entries frontend Presentation layer (visible to user) priority: low Issues/Tasks that are not so important UX/usability UX (User Experience): Methods for improving the usablitiy
Development

Successfully merging a pull request may close this issue.

4 participants