Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other: Migrate to Bootstrap 5 #851

Open
FinnRG opened this issue Apr 27, 2021 · 2 comments
Open

Other: Migrate to Bootstrap 5 #851

FinnRG opened this issue Apr 27, 2021 · 2 comments
Labels
Bootstrap CSS framework: Bootstrap 5 complexity: high 7 to 30 days of work (or longer), consider splitting feature request frontend Presentation layer (visible to user) priority: low Issues/Tasks that are not so important

Comments

@FinnRG
Copy link
Member

FinnRG commented Apr 27, 2021

Split from #6.

Bootstrap 5 beta 3 was released on March 22, 2021 and the stable release is expected to release in the next few months (https://github.com/twbs/release and twbs/bootstrap#31057).

A migration to v5 would make it much easier to increase responsiveness for mobile devices and facilitate the implementation of new frontend features.

@FinnRG FinnRG mentioned this issue Apr 27, 2021
18 tasks
@ycanardeau
Copy link
Contributor

ycanardeau commented May 8, 2021

@Pyther99 Is there any reason you want to stick with Bootstrap? There are some other frameworks like Material-UI and Primer. Think twice and make some experiments before you start working on this. (I've been spending a lot of time on deciding which of Angular, React and Vue I should use.) Migrating to a new CSS framework is lower priority compared to migration to React anyway. Before creating a pull request, you can (and/or should) do mockups how the user interface would look, and post screenshots here or on Discord. I'll merge the PR if and only if the design looks better than the current one. (I'm quite conservative when it comes to CSS design.)

@ycanardeau ycanardeau added the frontend Presentation layer (visible to user) label May 8, 2021
@FinnRG
Copy link
Member Author

FinnRG commented May 8, 2021

@ycanardeau I would choose Bootstrap 5 as the aim of the migration is not to change the design of the site, this definitely requires intensive testing and consultation on Discord, but to make the site mobile friendly and keep the current design. As VocaDB currently uses Bootstrap 2, this can best be achieved by continuing to use Bootstrap, apart from that it is a well proven framework and I don't really see a good reason to choose another framework. After the React migration, https://github.com/react-bootstrap/react-bootstrap could also be used (which, however, is still based on Bootstrap 4.6).

@ycanardeau ycanardeau added this to the Migrate to Bootstrap 5 (or similar) milestone May 22, 2021
@github-actions github-actions bot added the Stale label Jul 21, 2021
@ycanardeau ycanardeau removed the Stale label Jul 21, 2021
@github-actions github-actions bot added the Stale label Sep 20, 2021
@ycanardeau ycanardeau self-assigned this Sep 20, 2021
@ycanardeau ycanardeau removed their assignment Jul 4, 2022
@andreoda andreoda added Bootstrap CSS framework: Bootstrap 5 complexity: high 7 to 30 days of work (or longer), consider splitting and removed complexity: epic labels Apr 21, 2023
@VocaDB VocaDB deleted a comment from github-actions bot Apr 26, 2023
@VocaDB VocaDB deleted a comment from github-actions bot Apr 26, 2023
@FinnRG FinnRG removed this from the Migrate to Bootstrap 5 (or similar) milestone Apr 29, 2023
@andreoda andreoda added the priority: low Issues/Tasks that are not so important label Mar 23, 2024
@andreoda andreoda changed the title Migrate to Bootstrap 5 Other: Migrate to Bootstrap 5 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bootstrap CSS framework: Bootstrap 5 complexity: high 7 to 30 days of work (or longer), consider splitting feature request frontend Presentation layer (visible to user) priority: low Issues/Tasks that are not so important
Projects
Development

Successfully merging a pull request may close this issue.

4 participants