Switching to HOME should resume schedule

[JasonCzerak]

Thank you for this fork, it's much more reliable than the original.

I believe the idea to set "home" as an indefinite hold is flawed. This method means we'll only adhere to one heat/cool range all day, year round regardless of our sleep preferences. When we are home, we'll want the home, afternoon and sleep schedules to operate as we designed with in the Ecobee.

Having the "away" on indefinite makes sense and should stay as is.

Please allow the behavior of "home" to resume schedule as an option in the configuration page for the plugin. Below is a small hack I did to fix the resume vs hold

// Use setHold for all states (including home) to override built-in schedule

     let theType = "setHold";
     if (climateRef === "home") {
         theType = "resumeProgram"
     } 

       const setHoldBody = {
            'selection': {
                'selectionType': selectionType,
                'selectionMatch': selectionMatch,
            },
            'functions': [
                {
                    'type': theType,
                    'params': {
                        'holdType': 'indefinite', 
                        'holdClimateRef': climateRef,
                    },
                },
            ],
        };

[Vortec4800]

Glad you're getting use out of it. I agree with your statement here, if the plugin sets the thermostat to "hold" on home that's a bug and isn't intended.

Unfortunately I don't use Homebridge nor an Ecobee anymore so I can't really work on this. That said if you submit a PR I'm happy to merge it in.

[JasonCzerak]

I never really mess with github yet, i suppose this is a good spot to learn how it all works :D

If you're cool with the hack that did in the comments, I'll figure out the process to get things properly submitted here in a few days.

[jschwager]

@JasonCzerak Basically what you'll want to do is fork the repo, commit and publish your changes to your forked repo, and then open a pull request from your repo into this one.