-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better fine-grained 'scope' control (in normal manifest scope & scope extensions) #105
Comments
@dmurph Thank you for reaching out to me about this proposal @LuHuangMSFT FYI |
Amazing, thank you for this use-case! This is incredibly valuable. @LuHuangMSFT I think this matches with our previous convo. Notes are here General conclusion currently:
Something kinda like this is the conclusion: "scope": "https://www.example.com/app/",
"scope_extensions": [
{ "type": "origin", "value": "https://helpcenter.example-help-center.com" }
]
"scope_exclusions": [
// This apples to all origins, so this removes any url with the prefixes:
// https://www.example.com/app/scope/
// https://helpcenter.example-help-center.com/app/scope/
"/app/about/",
// These only apply to the specific origins
"https://helpcenter.example-help-center.com/abcd/"
"https://www.example.com/app/phone-numbers",
] Spec psuedo: When evaluating if a url is controlled by the app (in scope of the app), the url must be within the manifest scope or the extended scope, but cannot be within scope exlusions. possible psuedo algorithm:
|
@dmurph - Is there a reason why |
@HowardWolosky said:
It can - if we want to make it extensible with the "type" and "value" fields, that can totally work. "type" maybe is "path_prefix" and "url_prefix"? That might make more sense for devs. We can totally iterate on design there. I think the main "pro" of having this be separate from
But - if everyone else things we should just put this in the scope_extensions with types like "excludePathPrefix" and "excludeUrlPrefix", then I'm OK with that too. |
We have another use-case here from a partner:
|
Adding to what Dan mentioned, it would be ideal for an app to specific paths which are capturable. e.g. https://other.domain.com/app and everything else is non-capturable. |
@vatanaggarwal said:
At that point this gets more complicated - if we're doing both inclusions & exclusions, the UrlPattern solution becomes more interesting maybe, but I know discussions there ended up stalling in the past as it got complicated. There is also compatibility with other OS's to consider here and @LuHuangMSFT I believe has the most expertise. I think, for example, Android supports some stuff with basic patterns and prefixes. I'm not sure what you can do on iOS. |
See w3c/manifest#996 as well - likely as a better overarching topic |
@jacobamills @vatanaggarwal Could you see a need to allow configuring navigation capture filters differently than scope filters? I.e. the 2 sets are not identical? |
In scope_extensions-explainer.md#future-extensions the following is mentioned as a possibility:
For Google Meet, this is a blocker for us to be able to enable link capturing, as there are specific paths within our application that we do not want our PWA to handle.
Because our meeting codes are defined on the root path (e.g. meet.google.com/aaa-bbbb-ccc), we would specifically need path exclusion, rather than just inclusion. For example, we would want to be able to:
The text was updated successfully, but these errors were encountered: