Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Web IDL type for URLs in Protected Audience (formerly FLEDGE) #1376

Open
1 task
dontcallmedom-bot opened this issue Jan 6, 2025 · 2 comments
Open
1 task

Comments

@dontcallmedom-bot
Copy link

While crawling Protected Audience (formerly FLEDGE), wrong Web IDL type for URLs:

  • field url in dictionary AdRender uses DOMString instead of recommended USVString for URLs

Cc @dontcallmedom @tidoust

This issue was detected and reported semi-automatically by Strudy based on data collected in webref.

@MattMenke2
Copy link
Contributor

Relatedly, we don't run it in an environment that actually has access to the standard Javascript value to IDL magic, so I'm not sure how accurate any of the annotations for types accepted by methods provided to bid scripts are, compared to our current implementation.

@morlovich
Copy link
Collaborator

I put in a bunch of effort to match the IDL precisely. Well, except for an arbitrary cap of 100 on sequences.

(Though I didn't add support for USVString, I seem to recall there was some annoyance about how conversion to utf-8 happens making checking it frustrating).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants