Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can the upper pin on pymatgen be removed? #316

Closed
CompRhys opened this issue Sep 26, 2024 · 2 comments · Fixed by #318
Closed

Can the upper pin on pymatgen be removed? #316

CompRhys opened this issue Sep 26, 2024 · 2 comments · Fixed by #318

Comments

@CompRhys
Copy link
Contributor

SMACT/setup.py

Line 57 in 62079a3

"pymatgen>=2024.2.20,<2024.8.8",

Currently there is a pin on the most recent pymatgen version that can be used, is this necessary at this point? If so can I assist in any way to fix the incompatibility?
@AntObi
Copy link
Collaborator

AntObi commented Sep 26, 2024

Hi @CompRhys, I believe I originally set that pin due to materialsproject/pymatgen#3990 causing the SMACT CI to fail on Windows. As that's been resolved, I can remove the pin. Will make that update shortly.

@AntObi AntObi mentioned this issue Sep 26, 2024
Merged
11 tasks
@AntObi
Copy link
Collaborator

AntObi commented Sep 26, 2024

@CompRhys Completed in #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump min python version to 3.10 and update metadata AntObi/SMACT
2 participants
@CompRhys @AntObi