[Bug]: Whisky hangs at startup

[luosheng]

Description

When Whisky starts, it might hang for 10+ seconds, depending on how many pinned programs are there.

It's because fetching the best icon for the program can take somehow up to 3 seconds for a program (tested on a MacBook Pro M1 Max). This happens on the main thread thus blocks the whole UI.

And for some reasons, PinView was loaded twice on startup, which doubled the hang time.

Steps to reproduce

Just pin 4~5 programs and launch Whisky. In my case, getting an icon for Cyberpunk 2077 takes the longest time.

Expected behaviour

Make the icon fetching running in the background and maybe cache the icons? Also make PinView only run once.

Logs

I added some logging to `PinView`'s `onAppear` and here's the output:

Fetching best icon for: Ugly
Execution Time: 1.070072054862976 seconds
Fetching best icon for: Agatha Christie - Murder on the Orient Express
Execution Time: 1.0541011095046997 seconds
Fetching best icon for: Cyberpunk2077
Execution Time: 2.8241089582443237 seconds
Fetching best icon for: Steam
Execution Time: 0.29903101921081543 seconds
Fetching best icon for: Agatha Christie - Murder on the Orient Express
Execution Time: 1.05880606174469 seconds
Fetching best icon for: Steam
Execution Time: 0.28040599822998047 seconds
Fetching best icon for: Cyberpunk2077
Execution Time: 2.7935760021209717 seconds
Fetching best icon for: Ugly
Execution Time: 1.066970944404602 seconds

What version of Whisky are you using?

2.2.1

What version of macOS are you using?

Sonoma (macOS 14)

Issue Language

• Yes my issue is written in English

[IsaacMarovitz]

Fixed by #670

[luosheng]

FYI, the double loading seems to have something to do with the bottomBar modifier.