Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] User should not be able to add drawings, or elements, to tweened frames. #54

Open
Luxapodular opened this issue Jan 6, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@Luxapodular
Copy link
Member

Describe the bug
When adding drawings or elements to a tweened frame, undefined behavior can occur since tweened frames expect the entire frame's context to be a Clip.

To Reproduce
Steps to reproduce the behavior:

  1. Create a drawing on the canvas.
  2. Extend the frame to any length over 1.
  3. Create a tween and tween the elements of that frame (tweening position is the most visual).
  4. Attempt to draw on that frame.
  5. Play the project.
  6. See error.

Expected behavior
Drawing should be disallowed on tweened frames.

@Luxapodular Luxapodular added the bug Something isn't working label Jan 6, 2020
@Luxapodular
Copy link
Member Author

Attempt #1, simply disallowing adding children to tweened frames, did not work as applyChanges / applyDrawableChanges removes and re-adds ever object on every canvas modified...

Need to be able to add objects without removing literally everything off of the canvas.

@Luxapodular
Copy link
Member Author

Looks like we'll need to check if an object exists on the frame, and update the objects if a change is made rather than remove and re-add the objects.

@dumblob
Copy link

dumblob commented Feb 17, 2022

Related: #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants