Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pass_time.py to remove duplication of aqua/terra code, use an ISO 8601 date format (rather than MM-DD-YYYY) #213

Open
Tracked by #149
hollandjg opened this issue Jan 15, 2025 · 4 comments

Comments

@hollandjg
Copy link
Collaborator

No description provided.

@cpaniaguam
Copy link
Member

@cpaniaguam
Copy link
Member

Also, is this related to #185?

@cpaniaguam
Copy link
Member

I am looking at SOIT's (satellite-overpass-identification-tool/satellite_overpass_identification_tool.py) output (see below) and the overpass times seem to be in ISO 8601 format. @hollandjg Could you fill in some details? This is still fresh in my mind so maybe I can address it quickly. Thanks.

date,satellite,overpass time
2020-09-04,aqua,2020-09-04T23:55:00Z
2020-09-04,terra,2020-09-04T23:39:32Z
2020-09-05,aqua,2020-09-05T23:00:03Z
2020-09-05,terra,2020-09-05T22:44:33Z
2020-09-06,aqua,2020-09-06T23:42:45Z
2020-09-06,terra,2020-09-06T23:27:20Z
2020-09-07,aqua,2020-09-07T22:47:52Z
2020-09-07,terra,2020-09-07T22:32:17Z

@hollandjg
Copy link
Collaborator Author

I am looking at SOIT's (satellite-overpass-identification-tool/satellite_overpass_identification_tool.py) output (see below) and the overpass times seem to be in ISO 8601 format. @hollandjg Could you fill in some details? This is still fresh in my mind so maybe I can address it quickly. Thanks.

date,satellite,overpass time
2020-09-04,aqua,2020-09-04T23:55:00Z
2020-09-04,terra,2020-09-04T23:39:32Z
2020-09-05,aqua,2020-09-05T23:00:03Z
2020-09-05,terra,2020-09-05T22:44:33Z
2020-09-06,aqua,2020-09-06T23:42:45Z
2020-09-06,terra,2020-09-06T23:27:20Z
2020-09-07,aqua,2020-09-07T22:47:52Z
2020-09-07,terra,2020-09-07T22:32:17Z

The outputs are now in ISO8601 (fixed during the pipeline updates), but the code within the pipeline still uses a non-standard date format. This is more a maintainability thing for the overpass identification tool than a problem with its interface.

There's still a lot of duplication around aqua/terra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants