New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DictId handling by LexiconSet #252

Open

mh-northlander opened this issue Nov 28, 2024 · 1 comment · Fixed by #256

Milestone

Collaborator

mh-northlander commented Nov 28, 2024

Currently dictionary id part of WordId is handled by several classes (LexiconSet, DoubleArrayLexicon, WordIdTable, ..).

DictId is for using multiple lexicons and LexiconSet should be responsible for modifying it.

The text was updated successfully, but these errors were encountered:

mh-northlander added this to the 0.8 milestone

Collaborator Author

mh-northlander commented Nov 28, 2024

By removing dictId handling from lexicon interface, we can reuse lexicons in multiple LexiconSet i.e. multiple dictionaries.

mh-northlander mentioned this issue

Handle dictid by lexiconset #256

Merged

mh-northlander linked a pull request

that will close this issue

Handle dictid by lexiconset #256

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment