Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger should know what regions of data are safe #640

Open
JelleAalbers opened this issue Nov 1, 2017 · 0 comments
Open

Trigger should know what regions of data are safe #640

JelleAalbers opened this issue Nov 1, 2017 · 0 comments

Comments

@JelleAalbers
Copy link
Contributor

Readers insert data asynchronously into the database, so at a given time the most recent data in the database is incomplete -- not all digitizers have contributed to it. The trigger queries data until a fixed time (one minute) away from the last pulse for this reason.

Such a fixed margin is not robust. If the database is too slow, or a pulse is accidentally inserted into the far future (some issues we had in the past), the trigger still queries a region of data it shouldn't, and the result is stretches of time where not all digitizers contribute.

Dan already implemented a 'status' database collection where the digitizers keep track of which collections are safe to read. There's also at least a start of code in the trigger to use this. When there is time, we should test if this works well and switch to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant