Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scada calls fail if float times are used due to using len(str(start)) to do log10(start) #491

Closed
kdund opened this issue May 14, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kdund
Copy link
Contributor

kdund commented May 14, 2021

The line here:

if len(str(start)) < 19 or len(str(end)) < 19:

uses the length of the string representation of the number to do log10
that works for ints, not for floats.
If only ints are to be used, I think a separate test should be done for this.

@kdund kdund self-assigned this May 15, 2021
@JoranAngevaare JoranAngevaare added the bug Something isn't working label May 17, 2021
@JoranAngevaare
Copy link
Contributor

Should be fixed in #560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants