Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

International language not in effect #492

Closed
mdddj opened this issue Jan 29, 2024 · 2 comments
Closed

International language not in effect #492

mdddj opened this issue Jan 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mdddj
Copy link

mdddj commented Jan 29, 2024

image image
@mdddj mdddj added the bug Something isn't working label Jan 29, 2024
@MattKiazyk
Copy link
Contributor

Thanks @mdddj - it was my assumption that if a language didn't have a key it would use the default english language, but now using the .xcstrings that was a wrong assumption.

I'll have to go through and put in default english values in I guess, unless there's a way to default to english if a language value isn't there?

@MattKiazyk
Copy link
Contributor

Fixed a bunch of these to set the default english in #532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattKiazyk @mdddj