Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET Contacts cannot handle long list of IDs #471

Open
Tim-Hodge opened this issue Mar 13, 2023 · 2 comments
Open

GET Contacts cannot handle long list of IDs #471

Tim-Hodge opened this issue Mar 13, 2023 · 2 comments

Comments

@Tim-Hodge
Copy link

SDK you're using (please complete the following information):
3.31.0

Describe the bug
When calling GET /Contacts with a long list of IDs the response will be 404 The resource you're looking for cannot be found

To Reproduce
Steps to reproduce the behavior:

  1. Call GetContactsAsync with a list of IDs > 56
    or
  2. Call GET https://api.xero.com/api.xro/2.0/Contacts?IDs=... with a total URL length of >2091

Expected behavior
Expect a list of Contacts to be returned, or a helpful error to indicate that the URL was too long and could not be processed

Additional context
I've tested this out both with the SDK and against the API and it appears common to both. Unsure if this is also prevalent on other endpoints. I have tested IDs in the list independently and failure only occurs when the character count exceeds a limit. Limit can be reached/tested granularly by padding with an additional param, e.g. https://api.xero.com/api.xro/2.0/Contacts?IDs=[ids..]&padding=aaa

@github-actions
Copy link

PETOSS-281

@github-actions
Copy link

Thanks for raising an issue, a ticket has been created to track your request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant