Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP Restriction #233

Open
jonnsn opened this issue Apr 13, 2023 · 3 comments
Open

Add IP Restriction #233

jonnsn opened this issue Apr 13, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jonnsn
Copy link

jonnsn commented Apr 13, 2023

Is your feature request related to a problem? Please describe.
It would be nice if you could restrict marker depending on the IP Adress of the site.
Currently I can differenciate between eg. dev.* and sites not containing dev.* (using regex). The latter one includes also github for example. I would like to mark all none-dev-sites but they do not have a common address-fragment.

Describe the solution you'd like
Add an option to restrict marker to IP Range (CIDR Notation).

Describe alternatives you've considered
nothing I can think of

Additional context
nothing I can think of

@jonnsn jonnsn added the enhancement New feature or request label Apr 13, 2023
@XjSv
Copy link
Owner

XjSv commented May 16, 2023

It seems like there is no way to resolve domains natively in chrome. As for Firefox, they have a dns.resolve API that allows for this type of functionality.

I also attempted to use a third-party service like Google's or CloudFlares DNS API. But the issues with these is that they do not support localhost IP's.

e.g. https://dns.google/resolve?name=localhost

I'm assuming that you want the IP addresses to also resolve for localhost IP's so it will be useful web development. Am I correct in assuming this?

Also are you using Chrome, Firefox? The reason why I ask is because I am considering including this feature for Firefox only.

@jonnsn
Copy link
Author

jonnsn commented May 19, 2023

Thanks a lot for investigating!

I use Firefox :)
For local development I use ddev most of the time, which uses *.ddev.site urls. So I can use another rule for those anyway.

@XjSv
Copy link
Owner

XjSv commented May 19, 2023

Excellent, than I will include this feature for Firefox only in the next release.

Funny because I also use ddev most of the time, I'm constantly surprised my its popularity.

@XjSv XjSv added this to the Manifest v3 milestone Jun 6, 2023
@XjSv XjSv removed this from Environment Marker Jun 6, 2023
@XjSv XjSv moved this from To Do to In Progress in Environment Marker Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants