-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit of 47 markers #349
Comments
Interesting, I have not noticed this but then again I have not tested it with so many markers. I don't think there is any limit in the code in any way. The only thing that I can think of is since it is using the chrome.storage.sync API maybe its hitting the limit.
https://developer.chrome.com/docs/extensions/reference/api/storage#properties_4 I have to do some testing but if this is the issue maybe I can show a warning or have an option to offload the markers from the sync storage. The settings can stay but the markers can be just stored locally. |
Another tool, actually with same name of yours with a red ink pen logo ;) , allowed less than 47. And the Site Labeler allowed 35 or a bit more. May I suggest to use a gdrive link storage where the user has RW access to then cloud save it ? It would be awesome and in constant sync ! |
I was thinking of adding an option in the settings such as "Don't Sync Marker Data". This way, for the small amount of users that are hitting the storage.sync limit, they can enable this and storage.local will be used instead, which has a limit of 10MB. That should be plenty for markers. I understand this could be a pain with users like you have have over 50 markers configured, but I figure that the export/import feature would help with this. |
Describe the bug
I´ve being using this addon for a while moving from another that was working but had limitations and because your environment-marker has import/export options.
Today I noticed that could not add more markers and by exporting and counting the export file entries, theres 50 markers added.
So seems that the tool, besides great, its soft limited to 47 entries.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should be able to add as much entries for markers as I need
Screenshots
Not applicable due to personal data and as no visible error is produced.
Information (please complete the following information):
Additional context
n/a
The text was updated successfully, but these errors were encountered: