Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit of 47 markers #349

Open
theunf opened this issue Nov 26, 2024 · 3 comments
Open

Limit of 47 markers #349

theunf opened this issue Nov 26, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@theunf
Copy link

theunf commented Nov 26, 2024

Describe the bug
I´ve being using this addon for a while moving from another that was working but had limitations and because your environment-marker has import/export options.

Today I noticed that could not add more markers and by exporting and counting the export file entries, theres 50 markers added.

So seems that the tool, besides great, its soft limited to 47 entries.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure you have 47 markers added
  2. Export the markers to a file
  3. Try to add a new entry for a new URL. It wont produce an error but you wont be able to test the marker on new URL
  4. Export again the markers to a new file and compare them
  5. The bug is silent but you wont be able to go beyond 47 entries

Expected behavior
It should be able to add as much entries for markers as I need

Screenshots
Not applicable due to personal data and as no visible error is produced.

Information (please complete the following information):

  • OS: MacOS Sonoma 14.7.1 on Macbook AIR M1 2020
  • Browser Brave [Version 1.73.91 Chromium: 131.0.6778.85 (Official Build) (arm64)]
  • Browser Chrome [Version 131.0.6778.86 (Official Build) (arm64)]
  • Extension Version [v1.1]

Additional context
n/a

@theunf theunf added the bug Something isn't working label Nov 26, 2024
@theunf theunf changed the title Limit of 50 markers Limit of 47 markers Nov 26, 2024
@XjSv
Copy link
Owner

XjSv commented Nov 26, 2024

Interesting, I have not noticed this but then again I have not tested it with so many markers.

I don't think there is any limit in the code in any way. The only thing that I can think of is since it is using the chrome.storage.sync API maybe its hitting the limit.

storage.sync
If syncing is enabled, the data is synced to any Chrome browser that the user is logged into. If disabled, it behaves like storage.local. Chrome stores the data locally when the browser is offline and resumes syncing when it's back online. The quota limitation is approximately 100 KB, 8 KB per item. We recommend using storage.sync to preserve user settings across synced browsers. If you're working with sensitive user data, instead use storage.session.

https://developer.chrome.com/docs/extensions/reference/api/storage#properties_4

I have to do some testing but if this is the issue maybe I can show a warning or have an option to offload the markers from the sync storage. The settings can stay but the markers can be just stored locally.

@theunf
Copy link
Author

theunf commented Nov 26, 2024

Another tool, actually with same name of yours with a red ink pen logo ;) , allowed less than 47. And the Site Labeler allowed 35 or a bit more. May I suggest to use a gdrive link storage where the user has RW access to then cloud save it ? It would be awesome and in constant sync !

@XjSv
Copy link
Owner

XjSv commented Nov 26, 2024

I was thinking of adding an option in the settings such as "Don't Sync Marker Data".

This way, for the small amount of users that are hitting the storage.sync limit, they can enable this and storage.local will be used instead, which has a limit of 10MB. That should be plenty for markers.

I understand this could be a pain with users like you have have over 50 markers configured, but I figure that the export/import feature would help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants