-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old OpenDaylight internal config system (CSS) YANG models #554
Comments
I would be ok with removing modules from ODP folder of what you proposed.. but certainly not the [email protected] module from ietf-extracted-YANG-modules and Cisco-IOS-XE-wireless-access-point-oper.yang from cisco/xe/16101 folder which are in there included too. but that is probably what you meant anyway. But still @tnadeau should have a last word for this and maybe @bclaise and @einarnn might have some opinion on this. |
These YANG modules are old. Yes, a cleanup, along with posting the latest YANG modules, would be welcome. |
These models are meant to mimic what is used in ODL, so the changes here are intended to reflect whats in the project. Please confirm that the project is ok with these mods and if so, please send a PR.
—Tom
… On Jan 21, 2019, at 11:04 PM, Michael Vorburger ⛑️ ***@***.***> wrote:
Modes such as the opendaylight-dom-broker-impl.yang <https://github.com/YangModels/yang/blob/master/experimental/odp/opendaylight-dom-broker-impl.yang> describe internal Java object wiring of OpenDaylight internal config system (CSS), and IMHO make no sense to / could never be of any real world interest outside of ODL's internal code...
Further and more importantly, these have long ago disappeared from OpenDaylight (me and others have replaced what this used to be used for by regular Java dependency injection; initially OSGi Blueprint XML and more recently even simpler @javax.annoation.Inject).
Would you guys like a PR to to git rm e.g. all of these <https://github.com/YangModels/yang/search?q=config%3Amodule-type&unscoped_q=config%3Amodule-type> ?
@tnadeau <https://github.com/tnadeau>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#554>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD3SbdmZPgHcnn-vGDGQuCkfhPwcOGR7ks5vFo21gaJpZM4aL5Lk>.
|
These have long ago disappeared from OpenDaylight.
|
Modes such as the opendaylight-dom-broker-impl.yang describe internal Java object wiring of OpenDaylight internal config system (CSS), and IMHO make no sense to / could never be of any real world interest outside of ODL's internal code...
Further and more importantly, these have long ago disappeared from OpenDaylight (me and others have replaced what this used to be used for by regular Java dependency injection; initially OSGi Blueprint XML and more recently even simpler
@javax.annotation.Inject
).Would you guys like a PR to to git rm e.g. all of these ?
@tnadeau
The text was updated successfully, but these errors were encountered: