From 1a8f9f4954fd3a94d6b75b8e3bcd2b2aca297be8 Mon Sep 17 00:00:00 2001 From: Stephen Arthur Date: Wed, 30 Jun 2021 14:16:52 -0700 Subject: [PATCH] Update the docs to remove 100% tracing example and clarify upstream/downstream behavior when overridden. --- README.md | 2 +- docs/source/configuring_zipkin.rst | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 714b676..a596af3 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ Features include: * Blacklisting specific route/paths from getting traced. -* `zipkin_tracing_percent` to control the percentage of requests getting sampled. +* `zipkin_tracing_percent` to control the percentage of requests getting sampled (starting at, and downstream from, this service). * Creates `http.uri`, `http.uri.qs`, and `status_code` binary annotations automatically for each trace. diff --git a/docs/source/configuring_zipkin.rst b/docs/source/configuring_zipkin.rst index 5ef0ffd..f39d9da 100644 --- a/docs/source/configuring_zipkin.rst +++ b/docs/source/configuring_zipkin.rst @@ -104,11 +104,17 @@ zipkin.stream_name zipkin.tracing_percent ~~~~~~~~~~~~~~~~~~~~~~ A number between 0.0 and 100.0 to control how many request calls get sampled. + + .. note:: + When your service is traced according to the tracing percentage, the + resulting trace will start at your service and will not include any upstream + clients. + Defaults to `0.50`. Example: .. code-block:: python - 'zipkin.tracing_percent': 100.0 # Trace all the calls. + 'zipkin.tracing_percent': 1.0 # Increase tracing probability to 1% zipkin.trace_id_generator