Consequent use of version number in deprecated methods

[andizer]

We use same ways of showing version numbers when call deprecated_function. In the most situations the WPSEO prefix (e.g. WPSEO 7.9) way has been applied. In the other cases only the version number (e.g. 11.0) has been given as argument.

We should agree to use one of both forms and stick to that agreement to prevent differences in the codebase.

[jrfnl]

My opinion: always use WPSEO x.x.x as otherwise the deprecation message could be interpreted as coming from WP Core.
I realize that Core is nowhere near the higher version numbers of WPSEO, but being crystal clear about this is the best practice.

[andizer]

I agree. This means we have to prefix the non WPSEO occurrences.

[andizer]

Is it possible and a good idea to have a rule for this in the coding standards?

[jrfnl]

@andizer Indeed it is. Would you mind opening an issue for this in the YoastCS repo ?

[jrfnl]

YoastCS issue: Yoast/yoastcs#152

[Djennez]

Is it sufficient to only keep the issue in the YoastCS repo open and close this one? Or is this one for the actual changing and the other one for the CS rule?

[jrfnl]

@Djennez The YoastCS issue is for adding a sniff to detect this automatically (a sniff like this will actually go into WPCS).

This issue is to fix the non-compliance within WPSEO. and should stay open until the non-compliant instances in WPSEO have been fixed.

[Djennez]

What I thought 👍 Thanks!