We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seems like word count is not working for „nested“ inner blocks (https://www.advancedcustomfields.com/resources/acf_register_block_type/, „Adding inner blocks“) as the current implementation excludes the parent/embedding blocks.
e.g.
yoast-acf-analysis/js/yoast-acf-analysis.js
Line 245 in 48b01c7
yoast-acf-analysis/js/src/collect/collect-v5.js
Line 44 in 48b01c7
jQuery( '[data-block="${block.clientId}"] .acf-block-preview' ).length in this case returns > 1 and the block will be ignored.
jQuery( '[data-block="${block.clientId}"] .acf-block-preview' ).length
Changing the condition to .length >= 1 fixed it for me - not knowing, if this breaks somewhere else. 🤷 Is there a reason why it is set to === 1?
.length >= 1
=== 1
All contents should be recognized, even if nested in another block
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Please give us a description of what happened.
Seems like word count is not working for „nested“ inner blocks (https://www.advancedcustomfields.com/resources/acf_register_block_type/, „Adding inner blocks“) as the current implementation excludes the parent/embedding blocks.
e.g.
yoast-acf-analysis/js/yoast-acf-analysis.js
Line 245 in 48b01c7
and
yoast-acf-analysis/js/src/collect/collect-v5.js
Line 44 in 48b01c7
jQuery( '[data-block="${block.clientId}"] .acf-block-preview' ).length
in this case returns > 1 and the block will be ignored.Changing the condition to
.length >= 1
fixed it for me - not knowing, if this breaks somewhere else. 🤷Is there a reason why it is set to
=== 1
?Please describe what you expected to happen and why.
All contents should be recognized, even if nested in another block
How can we reproduce this behavior?
Technical info
The text was updated successfully, but these errors were encountered: