Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content analysis only working when ACF block is in edit mode when block registered via JSON #326

Open
2 tasks done
joshuakern opened this issue Jan 9, 2023 · 8 comments

Comments

@joshuakern
Copy link

joshuakern commented Jan 9, 2023

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

After registering an ACF block via JSON using the default preview mode, the block content is only analyzed when the block is in edit mode. When switching back to the preview mode, the block content is no longer analyzed and the Yoast analysis reverts back to previous numbers as if the block didn't exist.

JSON block example:

{
		"name": "acf/hero",
		"title": "Hero",
		"acf": {
				"mode": "preview",
				"renderTemplate": "hero.php"
		}
}

Please describe what you expected to happen and why.

I would expect the content to be analyzed on page load and regardless of switching between block modes.

How can we reproduce this behavior?

  1. Register ACF block via json with default preview mode
  2. Switch between block modes in block editor

Technical info

  • WordPress version: 6.1.1
  • ACF Content Analysis for Yoast SEO version: 3.0.1
  • Yoast SEO version: 19.13
  • ACF type: pro
  • ACF version: 6.0.6
  • Relevant plugins in case of a bug:
@nowakpiotrek
Copy link

The same issue is happening to me on multiple sites.

@virik
Copy link

virik commented Jan 20, 2023

+1

2 similar comments
@KodeksAS
Copy link

+1

@zgillam
Copy link

zgillam commented Jun 2, 2023

+1

@DominiquePijnenburg
Copy link

Is there any plan to make ACF content analysis work with blocks in preview mode? All our blocks are configured to run in preview mode by default so in our case it would be really helpful to support this mode as well.

@BenjaminZekavica
Copy link

Same here :/ Hopefully it will be fixed soon. @moorscode @yoastbot Do you can check it please ? I have this issue in multiple WP versions started from 6.4 till current WP 6.6 release.

@melcarthus
Copy link

melcarthus commented Sep 27, 2024

The plugin could use a fix. I had to write a content analysis filter to fix this issue via javascript via their docs. Kind of pointless if yoast has support for ACF, but not for ACF inside core blocks and or custom blocks.

@suascat
Copy link

suascat commented Dec 20, 2024

Please inform the customer of conversation # 1208586 when this conversation has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants