Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of notes somewhat offset from the sustain #23

Open
BambooOnFire opened this issue Jan 15, 2025 · 3 comments
Open

Position of notes somewhat offset from the sustain #23

BambooOnFire opened this issue Jan 15, 2025 · 3 comments

Comments

@BambooOnFire
Copy link

BambooOnFire commented Jan 15, 2025

I don't know anyone also has the issue, but the output MIDI file has notes that are slightly before the sustain thus resulting in no sustain while it's clearly sustained in the audio. Results in something sounding very choppy. The model is the default one btw.

Screenshot 2025-01-15 at 9 54 27 PM
@Yujia-Yan
Copy link
Owner

Thanks for letting me know. I think the cause is that the current model does not consider compatibility between the highest probable notes and pedals.

@RemyThePianist
Copy link

RemyThePianist commented Jan 19, 2025

I noticed this as well. The current model works wonderfully aside from this small issue. Do you have any plans on releasing a new version with this fixed?

@Yujia-Yan
Copy link
Owner

I noticed this as well. The current model works wonderfully aside from this small issue. Do you have any plans on releasing a new version with this fixed?

Fixing this requires a small modification to the model that requires retraining. Unfortunately, I currently don't have bandwidth to work on this project due to completing my graduation and job search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants