Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game and MainGame - a bit redundant? #6

Open
Bravo555 opened this issue Jun 2, 2018 · 1 comment
Open

Game and MainGame - a bit redundant? #6

Bravo555 opened this issue Jun 2, 2018 · 1 comment

Comments

@Bravo555
Copy link
Member

Bravo555 commented Jun 2, 2018

pygame.init()

pygame.init()

As you can see, you initialize pygame two times. But it isn't the only issue.

In main_game.py you have a bunch (rather, a fucking ton) of references to Game object and implement all the methods there.

I can see that this decoupling of structure/behaviour is used in C++.
But this isn't C++.

What you need to do

IMHO just move all the methods to game.py where they belong and instantiate Game object in main.py.

If you have any questions, feel free to ask.

@molendzik
Copy link
Contributor

we we pal gume spoko jest

@ZSAInfProject ZSAInfProject locked as too heated and limited conversation to collaborators Jun 13, 2018
@ZSAInfProject ZSAInfProject unlocked this conversation Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants