You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many apps contain old constructs that are no longer needed, but might be picked up as good practices by new contributors (or, in some cases, will prevent the app from working at all - though unlikely because generally backwards compatibility is preserved). So, refactoring those would help.
Old and outdated practices include:
Using Printer(ffs(string, o.cols)) instead of PrettyPrinter(string)
Using init_app in function-based apps just to set i and o (can be removed entirely in that case)
Redefining __init__ in class-based apps just to set self.menu_name (can be removed entirely in that case)
Not defining callback in function-based apps as a separate function
Defining the main_menu inside init_app and using a global to access it from callback
Adding ["Exit", 'exit'] entries to Menu elements (entry can just be removed)
All of these ought to be grepped for, then removed/replaced - afterwards, it's best if you test your changes by actually launching the app and confirming that it behaves the same way as it did previously.
The text was updated successfully, but these errors were encountered:
Many apps contain old constructs that are no longer needed, but might be picked up as good practices by new contributors (or, in some cases, will prevent the app from working at all - though unlikely because generally backwards compatibility is preserved). So, refactoring those would help.
Old and outdated practices include:
Printer(ffs(string, o.cols))
instead ofPrettyPrinter(string)
init_app
in function-based apps just to seti
ando
(can be removed entirely in that case)__init__
in class-based apps just to setself.menu_name
(can be removed entirely in that case)callback
in function-based apps as a separate functionmain_menu
insideinit_app
and using a global to access it fromcallback
["Exit", 'exit']
entries toMenu
elements (entry can just be removed)All of these ought to be
grep
ped for, then removed/replaced - afterwards, it's best if you test your changes by actually launching the app and confirming that it behaves the same way as it did previously.The text was updated successfully, but these errors were encountered: