Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release of Crusader? #77

Closed
richb-hanover opened this issue Sep 15, 2024 · 6 comments
Closed

Next release of Crusader? #77

richb-hanover opened this issue Sep 15, 2024 · 6 comments

Comments

@richb-hanover
Copy link
Contributor

I seem to be running out of things to complain about :-) Is it time to start thinking of another release?

Here are my outstanding questions. Do you want to address any of them?

Thanks!

image
@richb-hanover
Copy link
Contributor Author

@Zoxc PS I want to emphasize that I think Crusader is getting extremely good... Thanks again

@Zoxc
Copy link
Owner

Zoxc commented Sep 15, 2024

  • Better error message when peer can speak to server

That can probably be done after a 0.3 version.

  • I noticed an odd commit hash in the GUI I built just now.

The build script that fetches the Git commit runs when crusader-lib changes which didn't happen here.

  • Changing order of the plots colors both in GUI and in the PNG

I'd need to change the egui_plot crate for that.

@richb-hanover
Copy link
Contributor Author

These are all great answers. Do you think we're looking at a 0.3 release soon? (That would delight me, and maybe also Dave Täht, who's giving a talk on Wednesday...)

As I see it, we'd need to do the following:

  • No code changes (unless you know of any burning issues)
  • Bump the version to 0.3 (or 1.0?)
  • Build the releases, push to the Releases page
  • Update screen shots in the README showing the new version number
  • Publish an UNDERSTANDING.md page, with the text similar to First cut at documentation for "numerical summary window"  #78 (I'd welcome your comments)
  • Final editorial pass over all the documentation

I could do the last three items within 24 hours of getting the new release (so I can take screen shots) Thanks

@Zoxc
Copy link
Owner

Zoxc commented Sep 16, 2024

Well you got yourself a release and some plot legend reordering.

@richb-hanover
Copy link
Contributor Author

Well you got yourself a release and some plot legend reordering.

Thanks! The 0.3 release is a thing of beauty! I'd like to get comments on the documentation PR. Thanks again

@richb-hanover
Copy link
Contributor Author

PS - Crusader was mentioned a couple times at today's Linux Plumbers conference session: https://lpc.events/event/18/contributions/1967/attachments/1491/3153/State%20of%20the%20Bloat.pdf

Congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants