Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent behavior between accessor methods with source kwarg #14

Open
aaron-schroeder opened this issue Oct 29, 2022 · 0 comments
Open
Labels
Refactor Internal refactoring of code

Comments

@aaron-schroeder
Copy link
Owner

I noticed a lot of repeated behavior that seems like it might benefit from being refactored into a common pattern.

Specifically came up with record-generating methods (like XXX):

  • What to do if the source field(s) are missing (eg the records DataFrame is missing lat or lon columns when df.distance.records_from_position() ... currently returns None I think).
  • What to do if the field already exists in the records DataFrame and the method is called with inplace=True.
  • Re-usable behavior that allows choice between ['records', 'laps', 'summary', {other methods using records from other field(s)}
@aaron-schroeder aaron-schroeder added enhancement New feature or request Refactor Internal refactoring of code and removed enhancement New feature or request labels Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code
Projects
None yet
Development

No branches or pull requests

1 participant