New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probably should store domain separator as a constant in the constructor. #21

Open

pakim249CAL opened this issue Feb 28, 2022 · 0 comments

Contributor

pakim249CAL commented Feb 28, 2022

ghst-staking/contracts/wamGHST.sol

Line 358 in b6c888f

    
           return keccak256(abi.encode(EIP712_DOMAIN, keccak256(bytes(name())), keccak256(EIP712_REVISION), chainId, address(this)));

also, EIP2612 defines DOMAIN_SEPARATOR, not getDomainSeparator. probably a good idea to change this to conform to standards.

Timidan mentioned this issue

Add wamGHST pool #19

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment