Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Registration into Server and Direct #8

Open
judgej opened this issue Aug 24, 2013 · 2 comments
Open

Split Registration into Server and Direct #8

judgej opened this issue Aug 24, 2013 · 2 comments

Comments

@judgej
Copy link
Member

judgej commented Aug 24, 2013

The Registration class is going to get pretty big once SagePay Direct is added. Instead, it should be split into Direct and Server classes. We already have a Shared class for the shared services.

A Common class will be needed for the functionality that all three share.

Registration can inherit Server for backwards compatibility, but otherwise be deprecated.

@judgej
Copy link
Member Author

judgej commented Sep 3, 2013

This has been split now into Direct, Server and Shared.

Since Direct and Server extend Shared, and Shared extends Common (and it the only extension), I think Common is a misnomer. It should be a service abstract class (perhaps ServiceAbstract) and so should be renamed.

@judgej
Copy link
Member Author

judgej commented Sep 3, 2013

Please note that Register has been kept but deprecated. It expends Server, so offers legacy support (this re-factorisation should not break applications that use the library already - I'm trying to be careful about that). But tests - damn I need to write some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant