Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communities page SEO #312

Closed
wants to merge 12 commits into from
Closed

Communities page SEO #312

wants to merge 12 commits into from

Conversation

WishingWell13
Copy link
Contributor

@WishingWell13 WishingWell13 commented Dec 25, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #310 (Remove if there isn't an issue this fixes. If this relates to an internal Notion issue, link to that instead (or in addition to))

Fixes #308

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Logistical Change (something about code process / a readme change / documentation update)
  • CI Change (relating to deployment / continuous integration)
  • Something Else

How Has This Been Tested?

  • Tested on Localhost (Desktop)
  • Tested on Localhost (Mobile) - use https://ngrok.io to get a copy on a mobile device
  • Tested on Deployed Preview (Desktop)
  • Tested on Deployed Preview (Mobile)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code as needed, particularly in hard-to-understand areas
  • My changes generate no new warnings (if they do, please explain why)

Images:

image image

Adjusted position of title text also

Clicking navigation goes to that portion of the text (IE Clicking AI logo goes to AI section)
Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
main-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 1:27am

No navigation to initiatives yet
@SheepTester
Copy link
Member

On mobile clicking on the links on the top go to a 404 page, and you can't select the initiatives tab

Screenshot_20250106-183748

Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suppose it works

<button onClick={() => setSelected("ai")}>
<button
onClick={() => {
window.location.href = "#AI";
Copy link
Member

@SheepTester SheepTester Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of setting window.location.href, you can also use <a href="#AI">, which comes with the benefits of using native links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using buttons? Or use a nested link?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah instead of using buttons

@SheepTester
Copy link
Member

Merged as part of #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communities Page Image Updates Desktop Communities Page SEO Updates & Title Text
2 participants