-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communities page SEO #312
Communities page SEO #312
Conversation
Adjusted position of title text also Clicking navigation goes to that portion of the text (IE Clicking AI logo goes to AI section)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No navigation to initiatives yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suppose it works
<button onClick={() => setSelected("ai")}> | ||
<button | ||
onClick={() => { | ||
window.location.href = "#AI"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of setting window.location.href, you can also use <a href="#AI">
, which comes with the benefits of using native links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using buttons? Or use a nested link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah instead of using buttons
Merged as part of #313 |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #310 (Remove if there isn't an issue this fixes. If this relates to an internal Notion issue, link to that instead (or in addition to))
Fixes #308
Type of change
How Has This Been Tested?
Checklist:
Images: