Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can mglaman/drupal-check be excluded from install? #3765

Closed
dinoamino opened this issue Jul 19, 2019 · 3 comments
Closed

Can mglaman/drupal-check be excluded from install? #3765

dinoamino opened this issue Jul 19, 2019 · 3 comments
Labels
Support A support request

Comments

@dinoamino
Copy link

I cannot install BLT 10.2 due to dependency problems with sensiolabs-de/deprecation-detector

I know that BLT is not the issue - I already tried adding it via composer months ago and ran into the same issues then. I already have a solution for running drupal-check against our custom code using docker.

I am not interested in resolving these dependency issues.

I am interested in installing 10.2 and somehow excluding the deprecation-detector altogether.

What are my options here?
@dinoamino dinoamino added the Support A support request label Jul 19, 2019
@danepowell
Copy link
Contributor

BLT 10.2 has no dependency on sensiolabs-de/deprecation-detector that I'm aware of. Why do you think such a dependency exists?

Assuming I'm mistaken, what is the conflicting package?

@danepowell danepowell added the Awaiting response Maintainer needs more info label Jul 22, 2019
@dinoamino
Copy link
Author

dinoamino commented Jul 23, 2019 •
edited
Loading

My mistake, I meant mglaman/drupal-check
How can I just ignore this? It's a nice-to-have for me.

This is the mess of conflicts I get. I got the same conflicts a while back when I tried to manually add drupal-check to our composer.json:

    - Conclusion: don't install sensiolabs-de/deprecation-detector dev-master
    - Conclusion: don't install nikic/php-parser v3.1.5
    - Conclusion: don't install acquia/blt 10.2.1
    - Conclusion: don't install mglaman/drupal-check 1.0.12
    - phpstan/phpstan 0.11.10 conflicts with mglaman/drupal-check[1.0.10].
    - phpstan/phpstan 0.11.11 conflicts with mglaman/drupal-check[1.0.10].
    - phpstan/phpstan 0.11.12 conflicts with mglaman/drupal-check[1.0.10].
    - phpstan/phpstan 0.11.9 conflicts with mglaman/drupal-check[1.0.10].
    - phpstan/phpstan 0.11.7 conflicts with mglaman/drupal-check[1.0.10].
    - phpstan/phpstan 0.11.8 conflicts with mglaman/drupal-check[1.0.10].
    - acquia/blt 10.x-dev requires mglaman/drupal-check ^1.0.10 -> satisfiable by mglaman/drupal-check[1.0.10, 1.0.11, 1.0.12].
    - mglaman/drupal-check 1.0.11 requires phpstan/phpstan 0.11.x-dev#bf4e560b898dd77e5d4b22978e5fddece3d7a364 -> satisfiable by phpstan/phpstan[0.11.x-dev].
    - Conclusion: don't install phpstan/phpstan 0.11.x-dev
    - Conclusion: don't install nikic/php-parser v3.1.4
    - Conclusion: don't install nikic/php-parser v3.1.3
    - Conclusion: don't install nikic/php-parser v3.1.2
    - Conclusion: don't install nikic/php-parser v3.1.1
    - Conclusion: don't install nikic/php-parser v3.1.0
    - Conclusion: don't install nikic/php-parser v3.0.6
    - Conclusion: don't install nikic/php-parser v3.0.5
    - Conclusion: don't install nikic/php-parser v3.0.4
    - Conclusion: don't install nikic/php-parser v3.0.3
    - Conclusion: don't install nikic/php-parser v4.2.2
    - Conclusion: don't install nikic/php-parser v3.0.2
    - Installation request for sensiolabs-de/deprecation-detector (locked at dev-master) -> satisfiable by sensiolabs-de/deprecation-detector[dev-master].
    - Installation request for acquia/blt ^10.2.1 -> satisfiable by acquia/blt[10.2.1, 10.x-dev].
    - mglaman/drupal-check 1.0.10 requires mglaman/phpstan-junit ^0.11.1 -> satisfiable by mglaman/phpstan-junit[0.11.1, 0.11.2].
    - mglaman/phpstan-junit 0.11.2 requires phpstan/phpstan ^0.11.0 -> satisfiable by phpstan/phpstan[0.11, 0.11.1, 0.11.10, 0.11.11, 0.11.12, 0.11.2, 0.11.3, 0.11.4, 0.11.5, 0.11.6, 0.11.7, 0.11.8, 0.11.9, 0.11.x-dev].
    - mglaman/phpstan-junit 0.11.1 requires phpstan/phpstan ^0.11.0 -> satisfiable by phpstan/phpstan[0.11, 0.11.1, 0.11.10, 0.11.11, 0.11.12, 0.11.2, 0.11.3, 0.11.4, 0.11.5, 0.11.6, 0.11.7, 0.11.8, 0.11.9, 0.11.x-dev].
    - phpstan/phpstan 0.11 requires nikic/php-parser ^4.0.2 -> satisfiable by nikic/php-parser[4.2.x-dev, v4.0.2, v4.0.3, v4.0.4, v4.1.0, v4.1.1, v4.2.0, v4.2.1, v4.2.2].
    - phpstan/phpstan 0.11.1 requires nikic/php-parser ^4.0.2 -> satisfiable by nikic/php-parser[4.2.x-dev, v4.0.2, v4.0.3, v4.0.4, v4.1.0, v4.1.1, v4.2.0, v4.2.1, v4.2.2].
    - phpstan/phpstan 0.11.2 requires nikic/php-parser ^4.0.2 -> satisfiable by nikic/php-parser[4.2.x-dev, v4.0.2, v4.0.3, v4.0.4, v4.1.0, v4.1.1, v4.2.0, v4.2.1, v4.2.2].
    - phpstan/phpstan 0.11.3 requires nikic/php-parser ^4.0.2 -> satisfiable by nikic/php-parser[4.2.x-dev, v4.0.2, v4.0.3, v4.0.4, v4.1.0, v4.1.1, v4.2.0, v4.2.1, v4.2.2].
    - phpstan/phpstan 0.11.4 requires nikic/php-parser ^4.0.2 -> satisfiable by nikic/php-parser[4.2.x-dev, v4.0.2, v4.0.3, v4.0.4, v4.1.0, v4.1.1, v4.2.0, v4.2.1, v4.2.2].
    - phpstan/phpstan 0.11.5 requires nikic/php-parser ^4.0.2 -> satisfiable by nikic/php-parser[4.2.x-dev, v4.0.2, v4.0.3, v4.0.4, v4.1.0, v4.1.1, v4.2.0, v4.2.1, v4.2.2].
    - phpstan/phpstan 0.11.6 requires nikic/php-parser ^4.0.2 -> satisfiable by nikic/php-parser[4.2.x-dev, v4.0.2, v4.0.3, v4.0.4, v4.1.0, v4.1.1, v4.2.0, v4.2.1, v4.2.2].
    - Can only install one of: nikic/php-parser[4.2.x-dev, v3.1.5].
    - Can only install one of: nikic/php-parser[v4.0.2, v3.1.5].
    - Can only install one of: nikic/php-parser[v4.0.3, v3.1.5].
    - Can only install one of: nikic/php-parser[v4.0.4, v3.1.5].
    - Can only install one of: nikic/php-parser[v4.1.0, v3.1.5].
    - Can only install one of: nikic/php-parser[v4.1.1, v3.1.5].
    - Can only install one of: nikic/php-parser[v4.2.0, v3.1.5].
    - sensiolabs-de/deprecation-detector dev-master requires nikic/php-parser ~3.0 -> satisfiable by nikic/php-parser[v3.1.5, 3.x-dev, v3.0.0, v3.0.0alpha1, v3.0.0beta1, v3.0.0beta2, v3.0.1, v3.0.2, v3.0.3, v3.0.4, v3.0.5, v3.0.6, v3.1.0, v3.1.1, v3.1.2, v3.1.3, v3.1.4].
    - Conclusion: don't install nikic/php-parser v3.0.1|don't install mglaman/drupal-check 1.0.10|install phpstan/phpstan 0.11.10|install phpstan/phpstan 0.11.11|install phpstan/phpstan 0.11.12|install phpstan/phpstan 0.11.7|install phpstan/phpstan 0.11.8|install phpstan/phpstan 0.11.9|install phpstan/phpstan 0.11.x-dev|install nikic/php-parser v4.2.1|install nikic/php-parser v4.2.2
    - Conclusion: don't install nikic/php-parser v3.0.0|don't install mglaman/drupal-check 1.0.10|install phpstan/phpstan 0.11.10|install phpstan/phpstan 0.11.11|install phpstan/phpstan 0.11.12|install phpstan/phpstan 0.11.7|install phpstan/phpstan 0.11.8|install phpstan/phpstan 0.11.9|install phpstan/phpstan 0.11.x-dev|install nikic/php-parser v4.2.1|install nikic/php-parser v4.2.2
    - Conclusion: don't install nikic/php-parser v3.0.0beta2|don't install mglaman/drupal-check 1.0.10|install phpstan/phpstan 0.11.10|install phpstan/phpstan 0.11.11|install phpstan/phpstan 0.11.12|install phpstan/phpstan 0.11.7|install phpstan/phpstan 0.11.8|install phpstan/phpstan 0.11.9|install phpstan/phpstan 0.11.x-dev|install nikic/php-parser v4.2.1|install nikic/php-parser v4.2.2
    - Conclusion: don't install nikic/php-parser v3.0.0beta1|don't install mglaman/drupal-check 1.0.10|install phpstan/phpstan 0.11.10|install phpstan/phpstan 0.11.11|install phpstan/phpstan 0.11.12|install phpstan/phpstan 0.11.7|install phpstan/phpstan 0.11.8|install phpstan/phpstan 0.11.9|install phpstan/phpstan 0.11.x-dev|install nikic/php-parser v4.2.1|install nikic/php-parser v4.2.2
    - Conclusion: don't install nikic/php-parser v3.0.0alpha1|don't install mglaman/drupal-check 1.0.10|install phpstan/phpstan 0.11.10|install phpstan/phpstan 0.11.11|install phpstan/phpstan 0.11.12|install phpstan/phpstan 0.11.7|install phpstan/phpstan 0.11.8|install phpstan/phpstan 0.11.9|install phpstan/phpstan 0.11.x-dev|install nikic/php-parser v4.2.1|install nikic/php-parser v4.2.2
    - Conclusion: don't install nikic/php-parser 3.x-dev|don't install mglaman/drupal-check 1.0.10|install phpstan/phpstan 0.11.10|install phpstan/phpstan 0.11.11|install phpstan/phpstan 0.11.12|install phpstan/phpstan 0.11.7|install phpstan/phpstan 0.11.8|install phpstan/phpstan 0.11.9|install phpstan/phpstan 0.11.x-dev|install nikic/php-parser v4.2.1|install nikic/php-parser v4.2.2
    - Conclusion: don't install nikic/php-parser v4.2.1

So one or more of our 60+ other dependencies needs upgrading to make this work.

@no-response no-response bot removed the Awaiting response Maintainer needs more info label Jul 23, 2019
@dinoamino dinoamino changed the title Can deprecation-detector be excluded from install? Can mglaman/drupal-check be excluded from install? Jul 23, 2019
@danepowell
Copy link
Contributor

If I understand correctly, you want to use sensiolabs-de/deprecation-detector, but this conflicts with mglaman/drupal-check (a dependency of BLT). This conflict exists because deprecation-detector depends on "nikic/php-parser": "~3.0", whereas drupal-check depends on "nikic/php-parser": "^4.0.2".

Note that php-parser 3.x is extremely old and officially unsupported. Your best course of action would be to urge deprecation-detector to not use unsupported package versions. Follow these issues: qossmic/deprecation-detector#147, qossmic/deprecation-detector#145

The short answer is no, you cannot exclude this dependency from BLT. You might be able to use Composer version aliases to temporarily work around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Support A support request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danepowell @dinoamino