From 489687076d004e31d921b9693b80616c8ba3ec6f Mon Sep 17 00:00:00 2001 From: Julian <14220769+Qup42@users.noreply.github.com> Date: Sat, 24 Feb 2024 23:41:01 +0100 Subject: [PATCH] Fix `qlever stop` taking a long time (#29) The problem was that in the previous setup SIGNALS were not forwarded. Every `qlever stop` thus waited until docker forcefully terminated the container after 10s. `--init` starts an init process in the container that forwards SIGNALS. The containers now stop instantly. Some technical background: https://hynek.me/articles/docker-signals/ --- src/qlever/__main__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qlever/__main__.py b/src/qlever/__main__.py index 96d9c5db..b4cc3b91 100755 --- a/src/qlever/__main__.py +++ b/src/qlever/__main__.py @@ -579,6 +579,7 @@ def action_start(self, only_show=False): f" -w /index" f" --entrypoint bash" f" --name {docker_config['container_server']}" + f" --init" f" {docker_config['image']}" f" -c {shlex.quote(cmdline)}") else: