Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use irq_add_shared_handler() instead of fixed isr_dma_0() #9992

Open
dhalbert opened this issue Jan 23, 2025 · 0 comments
Open

Use irq_add_shared_handler() instead of fixed isr_dma_0() #9992

dhalbert opened this issue Jan 23, 2025 · 0 comments
Labels
rp2 Both RP2 microcontrollers
Milestone
9.x.x

Comments

@dhalbert
Copy link
Collaborator

ports/raspberrypi/audio_dma.c uses defines isr_dma_0() to handle all DMA 0 interrupts. Right now it's both audio and PIO. This is not recommended (see #9868 (comment)). Change to use irq_add_shared_handler() to set up handlers as needed.

We should document somewhere as well which DMA irq's are ok to share and which are used exclusively. RP2040 has DMA 0 and DMA 1. RP2350 has 0 through 3.
@dhalbert dhalbert added the rp2 Both RP2 microcontrollers label Jan 23, 2025
@dhalbert dhalbert added this to the 9.x.x milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rp2 Both RP2 microcontrollers
Projects
None yet
Milestone
9.x.x
Development

No branches or pull requests
1 participant
@dhalbert