Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] - separate lerna publishing for beta packages #2364

Open
Powerplex opened this issue Aug 13, 2024 · 0 comments
Open

[Chore] - separate lerna publishing for beta packages #2364

Powerplex opened this issue Aug 13, 2024 · 0 comments
Assignees
Milestone

Comments

@Powerplex
Copy link
Contributor

Powerplex commented Aug 13, 2024

Since Spark is using fixed versioning, every time a PR is merged, it publishes EVERY package on a synced version number.

This is what we wanted.

But, when we are developing a new component, we like to merge regularly and keep it in beta version. Fixed versioning breaks this, exemple:

  • I create a new @spark-ui/breadcrumb packages, and write 0.0.0-beta.0 in it's version.
  • The global (fixed) version in lerna.json is "version": "5.0.27",
  • I open a pull request ("fix") then merge it.
  • Lerna detects a change in at least one package, and publishes EVERY package to 5.0.28, including our @spark-ui/breadcrumb that should remain in beta.

Instead we should improve the process, so that when we merge, if the changes detected by lerna only concerns beta packages, it published them individually and preserved they independant versionning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants