Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7 has a breaking change with the upgrade of the peerDependency to React@19 #2559

Open
3 tasks
danieleloscozzese opened this issue Jan 21, 2025 · 1 comment
Open
3 tasks
Labels

Comments

@danieleloscozzese
Copy link
Contributor

Description

The v7 series above 7.3.3 has a breaking internal change after #2547.
Inter-package dependencies which are not pinned include the peer dependency on React 19 exclusive of v18 and break the installation in a tree which is still on v18. This is a breaking change and should have been the v8.

Is it possible to tag a v7.3.8 (being the most up to date patch of v7) which reverts the React v19 change? This is possible by releasing a non-latest tag, even manually, of the code at that version and would unblock us (we are Subito.it, Spark users).

We are more than happy to make the PR / branch but would not be able to release it ourselves.

Steps to reproduce

  1. Install @spark-ui/[email protected]
  2. Run npm ls react
  3. Transitively there is a dependency on React v19 from, for example, "@spark-ui/form-field": "^7.3.3" which resolves to v7.3.7.

Spark Component and Version

All v7 packages above v7.3.3

Browser

No response

Operating System

  • macOS
  • Windows
  • Linux

Additional Information

@spark-ui/[email protected]
│ │ ├─┬ @radix-ui/[email protected]
│ │ │ ├─┬ @radix-ui/[email protected]
│ │ │ │ ├─┬ @radix-ui/[email protected]
│ │ │ │ │ └── [email protected] deduped invalid: "^19.0" from node_modules/@spark-ui/alert-dialog/node_modules/@spark-ui/use-merge-refs, "^19.0" from node_modules/@spark-ui/checkbox/node_modules/@spark-ui/form-field, "^19.0" from node_modules/@spark-ui/checkbox/node_modules/@spark-ui/icon, "^19.0" from node_modules/@spark-ui/checkbox/node_modules/@spark-ui/icons, "^19.0" from node_modules/@spark-ui/checkbox/node_modules/@spark-ui/internal-utils, "^19.0" from node_modules/@spark-ui/checkbox/node_modules/@spark-ui/label, "^19.0" from node_modules/@spark-ui/checkbox/node_modules/@spark-ui/use-merge-refs <etc>
@Powerplex
Copy link
Contributor

Many changes happened in Spark following the recent aquisition of the company:

  • Only 1 developer remain (me)
  • The repository will be moved from adevinta organisation to leboncoin soon (still an open-source repo, but it might not last).
  • There is pressure to make Spark "Leboncoin only", we are trying to make it that no business logic ends up in the project, but now might be a good time for you to fork it. Their strategy is to split the assets per brand unfortunately.
  • They removed from the team people that were admin/owner of the workflow (CI, npm accounts, etc) I still have to get some admin rights for now I am a bit stuck.

I incorrectly tagged the PR after this one as the breaking change (React 19 update, removal of all forwardRef), for now can you use fixed versioning ? I will look to fix it but I have other feature to deliver right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants